feat: implement GetKey for KeyMap and DescriptorSecretKey
#851
+354
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- creates a new `key_map` module, and `KeyMap` type to replace the existing `BTreeMap` alias. - it's a commit extracted from superseded PR rust-bitcoin#765.
- add the implementation of GetKey for `KeyMap`, and also implements it for the inner type `DescriptorSecretKey` in order to make the match branching and logic clearer.
|
Mad, thanks man. I'm off travelling this week but can help review this when I get a chance if needed. I don't do many reviews in |
|
In 255a61e: You need to update Cargo-minimal.lock and Cargo-recent.lock to require Relatedly, your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #709
Description
I've built upon Tobin's work in #765 (see #765 (comment)) to implement the
GetKeytrait forKeyMap, a feature that will enable us to entirely remove the signers API frombdk_wallet, see: bitcoindevkit/bdk_wallet#70 and bitcoindevkit/bdk_wallet#235.Notes to the reviewers
I followed some of Poelstra's previous comments to reduce the number of required matching branches, and also some VM's suggestions on implementing the main
GetKeylogic forDescriptorSecretKeyinstead.Let me know if you have any other suggestions or comments.
Changelog notice